-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: environment handling windows (host mode) #1732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
==========================================
+ Coverage 61.22% 62.30% +1.07%
==========================================
Files 46 48 +2
Lines 7141 7579 +438
==========================================
+ Hits 4372 4722 +350
- Misses 2462 2527 +65
- Partials 307 330 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
wolfogre
reviewed
Apr 17, 2023
Co-authored-by: Jason Song <i@wolfogre.com>
wolfogre
approved these changes
Apr 18, 2023
KnisterPeter
approved these changes
Apr 18, 2023
@ChristopherHX this pull request has failed checks 🛠 |
mergify
bot
added
needs-work
Extra attention is needed
and removed
needs-work
Extra attention is needed
labels
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Currently we merge env variables with case sensitive key, this is problematic on windows where PATH and Path are the same key.
Other Changes considered:
Create a custom env type
However this would require a lot of changes across the codebase.
Next steps:
env
expressions context case sensitive again for non windows, because the env keys can be duplucated in the map